Bug #3709

Airport helipads don't have flashing lights

Added by PaulC 3 months ago. Updated 3 months ago.

Status:Closed Start date:2012-02-20
Priority:Normal Due date:
Assignee:- % Done:

100%

Category:Base
Target version:-

Description

Attached file should fix the problem. Why is the helipad part of the gui sprites though?

gui04.png (170.4 kB) PaulC, 2012-02-20 18:34

airports.png (32.1 kB) PaulC, 2012-02-21 17:28

Associated revisions

Revision 939:faf849af1075
Added by planetmaker 3 months ago

Fix #3709: Landing lights were inoperational for helipad and some broken at the heliport (PaulC)

Revision 943:7079bbe60bf0
Added by planetmaker 3 months ago

Fix #3709: Landing lights were inoperational for helipad and some broken at the heliport (PaulC)

History

Updated by planetmaker 3 months ago

Can you give me the sprite number(s) you mean so that I can check the source code for the graphics file(s) used?

Btw, the gui04.png file is indeed not well suitable to be modified: it's a big legacy bloat from one of the predecessor NewGRFs. If stuff is modified, it usually should be taken out and put in a separate file so that usage of this big bloat file is slowly phased out until we end up with useful separations.

All airport sprites should be, unless I'm mistaken, found (meanwhile) in sprites/png/infrastructure/airports.png though. Thus it should go either there or even a separate file :-)

Updated by PaulC 3 months ago

Sprite 306. It's part of action 5 type 15 (OTTD gui sprites), I was just wondering why that was as I've never seen it used as part of the gui, only in the airports.

The "helitower" is also missing one of the yellow flash colours, so I've fixed that as well.

Updated by planetmaker 3 months ago

Ah, that sprite. You wonder rightfully. IMHO it's quite wrongly placed in the GUI section.

But changing that and moving to the proper action5 type in the code and specs might not be worth the trouble.

Thanks for the sprite updates. Much appreciated.

Updated by planetmaker 3 months ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset faf849af1075.

Also available in: Atom PDF